document tilt improvements #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jan 2, 2024
saweber
force-pushed
the
tilt-improvements
branch
from
79d5eff to
9f222bd
Compare
saweber
force-pushed
the
tilt-improvements
branch
from
9f222bd to
f005957
Compare
saweber
force-pushed
the
tilt-improvements
branch
from
f005957 to
bc76e32
Compare
saweber
force-pushed
the
tilt-improvements
branch
from
bc76e32 to
71a4a24
Compare
Signed-off-by: Steven <[email protected]>
saweber
force-pushed
the
tilt-improvements
branch
from
71a4a24 to
c5cf30a
Compare
Signed-off-by: Steven Weber <[email protected]>
mattray
requested changes
Mar 4, 2024
| Optional. Defaults to 40000. | ||
| This is the port forwarded to localhost for delve. | ||
| Note: In `tilt_config.json`, this is a string and must be in quotes, since Tilt options must be a bool or a string. | ||
| - `port-prometheus` |
There was a problem hiding this comment.
I think Prometheus is listening on 80 inside the OpenCost cluster, does this forward 80 to 9080?
There was a problem hiding this comment.
Correct. The only configurable port through tilt is the 'local' side.
Signed-off-by: Steven Weber <[email protected]>
Signed-off-by: Steven Weber <[email protected]>
|
Issues addressed. I appreciate the detailed review! |
mattray
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document improvements contained in PRs:
opencost/opencost#2428
opencost/opencost-helm-chart#163