add debugPort value for tilt improvements #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2024
saweber
force-pushed
the
tilt-improvements
branch
4 times, most recently
from
f682cbb to
ef876b5
Compare
Signed-off-by: Steven <[email protected]>
saweber
force-pushed
the
tilt-improvements
branch
from
ef876b5 to
8e56355
Compare
mattray
requested changes
Jan 11, 2024
charts/opencost/Chart.yaml
Outdated
| @@ -9,7 +9,7 @@ keywords: | |||
| - kubecost | |||
| - opencost | |||
| - monitoring | |||
| version: 1.28.0 | |||
| version: 1.28.1 | |||
There was a problem hiding this comment.
If you could bump this to 1.28.2 I'll merge
Signed-off-by: Steven Weber <[email protected]>
Signed-off-by: Steven Weber <[email protected]>
mattray
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a nice to have for tilt; adding this value removes the requirement of changing existing values.yaml files for tilt usage.
Using the existing extraPorts value is insufficent, because helm
--setdoes not support appending a value to a array; it will only either override a specific index or the whole array (both have undesirable side effects).Related PRs:
opencost/opencost-website#189
opencost/opencost#2428