-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update oci source label #18
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Birger J. Nordølum <[email protected]>
0bd78b9
to
1231399
Compare
This is still Apache 2.0 right? Ed1t: just a quick question, will there ever be tagged releases of this project that is the same as opencost/opencost? I see perhaps now that changing this might break getting changelogs as Renovate will be unable to compare releases. 🤔 |
Yes it is still Apache 2.0, I've opened this PR for it: #19 The plan is to continue to tag and release in sync with opencost/opencost releases |
Thanks. I plan to submit a PR for a replacement with Renovate to rewrite from quay.io to ghcr.io. However, as I see it, that is only applicable for the opencost-ui and not the cost model as it's used by kubecost too? {
"matchPackageNames": ["quay.io/kubecost1/opencost-ui"],
"replacementName": "ghcr.io/opencost/opencost-ui",
"replacementVersion": "1.109.0"
} |
Now added to Renovate 37.401.6. 🥳 |
We officially switched OpenCost from quay.io to ghcr.io with the 1.109.0 release, but packages are still being published on quay.io for folks who haven't switched over yet. opencost-ui won't be published to quay.io. |
Having a replacement for Btw., publishing to quay has been disabled for a while now. At least it’s commented out in the workflow for build-publish. |
Kubecost maintains their own packaging repositories, the use of
"kubecost-cost-model" was a legacy name and is no longer used by them.
…On Tue, Jun 11, 2024 at 9:30 PM Birger J. Nordølum ***@***.***> wrote:
Having a replacement for quay.io/repository/kubecost1/kubecost-cost-model
to ghcr.io/opencost/opencost will not be correct as older versions of
kubecost also uses/used it?
Btw., publishing to quay has been disabled for a while now. At least it’s
commented out in the workflow for build-publish.
—
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQSJ53TZMBCLSURHOYGYDZG3NVLAVCNFSM6AAAAABJAGVGBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRQGUYTANRQG4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
So, to close this. Are you okay with a Renovate replacement for kubecost-cost-model too? Meaning, we will have the following: {
"matchPackageNames": ["quay.io/kubecost1/kubecost-cost-model"],
"replacementName": "ghcr.io/opencost/opencost",
"replacementVersion": "1.109.0"
},
{
"matchPackageNames": ["quay.io/kubecost1/opencost-ui"],
"replacementName": "ghcr.io/opencost/opencost-ui",
"replacementVersion": "1.109.0"
} That way, when Renovate is used, we can help people move over to the correct registry/image. |
That looks good except opencost-ui was just moved, so you would want the replacementVersion to be "1.110.0" |
What does this PR change?
Set the OCI source label to this repo.
Does this PR relate to any other PRs?
N/A.
How will this PR impact users?
Since I've worked on this for Renovate, people might loose grouping of this and normal opencost image. However, I plan to push an update to Renovate as well to fix this.
Does this PR address any GitHub or Zendesk issues?
N/A.
How was this PR tested?
Does this PR require changes to documentation?
N/A.
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?
N/A.