Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replacements): add opencost from quay.io to ghcr.io #29611

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

MindTooth
Copy link
Contributor

Changes

This replacement will help out with moving OpenCost images from their old registry (quay.io) to their new one (ghcr.io).

Maintainer has given a go ahead here.

Working pull requests:

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we match current version? Otherwise we're potentially upgrading and replacing in one go

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add match current value or version, so we only move latest good known version.

@MindTooth
Copy link
Contributor Author

I've added an explicit match now. Thanks, should have been obvious to me.

@MindTooth MindTooth requested a review from rarkins June 12, 2024 07:46
@HonkingGoose HonkingGoose requested a review from viceice June 12, 2024 09:57
@viceice viceice added this pull request to the merge queue Jun 14, 2024
Merged via the queue into renovatebot:main with commit b07f8bc Jun 14, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.408.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants