-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cranskhaft with aasdk next #18
base: crankshaft-ng
Are you sure you want to change the base?
Cranskhaft with aasdk next #18
Conversation
|
||
void AndroidAutoEntity::onVoiceSessionRequest(const aasdk::proto::messages::VoiceSessionRequest& request) | ||
{ | ||
OPENAUTO_LOG(error) << "[AndroidAutoEntity] voice session request not implemented"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note - I couldn't find anything that references "voice session" only video session and has more then just start and stop
Does this pr compile for you? I've tried to compile it, but am getting the following error.
|
My libaasdk.so was compiled off aasdk with newdev branch and then I added WifiInfoRequestMessage.proto back from master so yes it compiled .., I can add an MR opencardev/aasdk#20 to add the three deleted proto files back into aasdk, not familiar enough with the project to know why they where deleted. More info from aasdk maintainers would be good to see where they want to go with this. opencardev/aasdk@newdev...opencardev:aasdk:development is the stuff in develop branch that never made it to newdev |
I'll verify it builds and test it over the weekend |
I checked-out this pull request, and I needed to make the following edit to be able to compile:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems you have tried to use a different libgps version than what was previously used. is this intentional?
You seem to have resolved the resulting problems but someone really should write down the versions used for compilation (or at least the distro version!)
From what I can tell the original working version is libgps-dev=3.17-5
Make opencardev/openauto work with opencardev/aasdk newdev