Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated response-body of /v1/regard-application #574

Merged
merged 14 commits into from
Sep 10, 2024
Merged

Updated response-body of /v1/regard-application #574

merged 14 commits into from
Sep 10, 2024

Conversation

sunil-kumar-meena
Copy link
Collaborator

Fixes
#570

reviewer @PrathibaJee

PrathibaJee and others added 13 commits December 9, 2022 19:09
@PrathibaJee
Merge pull request #155 from openBackhaul:develop
752eb0a 
PrathibaJee/issue152
@openBackhaul
Merge pull request #201 from openBackhaul/alt_v2.n.m
bbaaeb7 
Specification of ApplicationLayerTopology v2.0.0
@openBackhaul
Merge pull request #235 from openBackhaul/alt_v2.n.m
f738824 
ALT v2.0.1
@IswaryaaS
Merge pull request #462 from openBackhaul/develop
a76a499 
To merge to main branch and to tag v2.0.1_impl and v2.0.1_test
@openBackhaul
Merge pull request #502 from openBackhaul/develop
efc6349 
ApplicationLayerTopology v2.1.0_spec
@openBackhaul
Merge pull request #504 from openBackhaul/develop
045f63e 
ALT v2.1.0_spec
@openBackhaul
Merge pull request #525 from openBackhaul/develop
bd671e4 
ApplicationLayerTopology v2.1.1_spec
@IswaryaaS
Merge pull request #563 from openBackhaul/develop
5a26257 
Merging develop to main to tag the v2.1.1_impl
@openBackhaul
Merge pull request #568 from openBackhaul/develop
98a7eea 
ApplicationLayerTopology v2.1.2_spec
@Sunilkumarmeena
Supported 2.1.2, removed response header's backendTime
1623dbb
@PrathibaJee
Merge pull request #573 from openBackhaul/Sunilkumar/issue569
78b5234 
 Supported 2.1.2, removed response header's backendTime
@Sunilkumarmeena
updated response-body of /v1/regard-application
dd95784
@Sunilkumarmeena
Merge branch 'v2.1.2_impl' into Sunilkumar/issue570
29f5517
PrathibaJee
PrathibaJee requested changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@PrathibaJee PrathibaJee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the review comments. Also after fixing the review comments, perform unit testing for the integer profile.

server/service/IntegerProfileService.js Show resolved Hide resolved
server/service/IntegerProfileService.js Show resolved Hide resolved
server/service/IntegerProfileService.js Show resolved Hide resolved
server/service/IntegerProfileService.js Show resolved Hide resolved
server/service/IntegerProfileService.js Show resolved Hide resolved
server/service/IntegerProfileService.js Show resolved Hide resolved
server/service/IntegerProfileService.js Show resolved Hide resolved
server/service/IntegerProfileService.js Show resolved Hide resolved
server/service/IntegerProfileService.js Show resolved Hide resolved
PrathibaJee
PrathibaJee approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@PrathibaJee PrathibaJee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the review comments.

@PrathibaJee PrathibaJee merged commit c8abb79 into develop Sep 10, 2024
2 checks passed
@PrathibaJee PrathibaJee deleted the Sunilkumar/issue570 branch September 10, 2024 07:08
@sunil-kumar-meena sunil-kumar-meena restored the Sunilkumar/issue570 branch September 11, 2024 10:27
@sunil-kumar-meena sunil-kumar-meena mentioned this pull request Sep 11, 2024
Merged
@PrathibaJee PrathibaJee mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrathibaJee PrathibaJee PrathibaJee approved these changes

@MartinSunal MartinSunal Awaiting requested review from MartinSunal MartinSunal is a code owner

@DanaSunal DanaSunal Awaiting requested review from DanaSunal DanaSunal is a code owner

@vanithavalluripalli9 vanithavalluripalli9 Awaiting requested review from vanithavalluripalli9 vanithavalluripalli9 is a code owner

@IswaryaaS IswaryaaS Awaiting requested review from IswaryaaS IswaryaaS is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sunil-kumar-meena @PrathibaJee @openBackhaul @IswaryaaS @Sunilkumarmeena