Updated response-body of /v1/regard-application #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunil-kumar-meena
requested review from
PrathibaJee,
MartinSunal,
DanaSunal,
vanithavalluripalli9 and
IswaryaaS
as code owners
Closed
PrathibaJee
requested changes
Sep 11, 2024
| @@ -106,7 +106,7 @@ async function RequestForInquiringTopologyChangeInformationWithDefaultKey(applic | |||
| let responseCode = response.status; | |||
| if (!responseCode.toString().startsWith("2")) { | |||
| result["successfully-connected"] = false; | |||
| result["reason-of-failure"] = `ALT_NOT_REACHABLE`; | |||
| result["reason-of-failure"] = `ALT_DID_NOT_REACH_NEW_APPLICATION`; | |||
There was a problem hiding this comment.
if (!responseCode.toString().startsWith("2")) , then you have to check whether the if responseCode.toString() == "408" to confirm that the application is actually not reachable. ( Note : Include the response code for which a not reachable scenario happen)
PrathibaJee
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
#570
Note: Last PR #574 got merged into develop branch, raising new PR again, also suggest do we have to revert the last changes from develop branch also?
reviewer @PrathibaJee