Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 [maykinmedia/django-setup-configuration#16] Setup config fixes #193

Closed
wants to merge 3 commits into from

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Oct 18, 2024

Fixes: maykinmedia/django-setup-configuration#16

reliant on maykinmedia/notifications-api-common#15 to verify if view-config is correct and maykinmedia/commonground-api-common#37

TODO:

  • view-config seems to be broken if you configure the service, due to notifications-api-common still using zds-client?

@stevenbal stevenbal marked this pull request as draft October 18, 2024 12:34
@SonnyBA
Copy link
Contributor

SonnyBA commented Oct 24, 2024

The common-ground-api PR was recreated (to allow the PR to be reviewed by @stevenbal)

ensure that notificaties API can access itself, to complete the configuration
and remove gemma-zds-client
@stevenbal
Copy link
Contributor Author

This has been fixed in the PR that implements a step to load subscriptions with the refactored setup configuration command: #209

@stevenbal stevenbal closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup_configuration opennotificaties NRC config not working
2 participants