♻️ [#200] Configure Autorisaties API connection via setup-configuration #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
feature/200-autorisaties-api-setup-configuration
branch
from
d10af57 to
504de3e
Compare
stevenbal
force-pushed
the
feature/200-autorisaties-api-setup-configuration
branch
3 times, most recently
from
b0c2f24 to
42e90c0
Compare
several steps have been moved to their respective libraries
stevenbal
force-pushed
the
feature/200-autorisaties-api-setup-configuration
branch
from
42e90c0 to
e222634
Compare
stevenbal
changed the title
stevenbal
force-pushed
the
feature/200-autorisaties-api-setup-configuration
branch
from
e222634 to
8edd632
Compare
This was referenced Dec 10, 2024
stevenbal
commented
Dec 10, 2024
SonnyBA
reviewed
Dec 10, 2024
|
|
||
| Authorization configuration | ||
| --------------------------- | ||
| TODO: add generated documentation for ``zgw_consumers.ServiceConfigurationStep`` |
There was a problem hiding this comment.
Are these TODO's to be generated later on?
There was a problem hiding this comment.
Yeah I wanted to add these placeholders to make sure we don't forget about it, but this will probably happen in january next year
stevenbal
force-pushed
the
feature/200-autorisaties-api-setup-configuration
branch
from
8edd632 to
6370661
Compare
stevenbal
force-pushed
the
feature/200-autorisaties-api-setup-configuration
branch
from
6370661 to
8a8e6e7
Compare
SonnyBA
approved these changes
Dec 12, 2024
src/nrc/tests/setup_configuration/files/setup_config_sites.yaml
Outdated
Show resolved
Hide resolved
stevenbal
force-pushed
the
feature/200-autorisaties-api-setup-configuration
branch
from
8a8e6e7 to
83857fc
Compare
annashamray
previously requested changes
Dec 13, 2024
swrichards
approved these changes
Dec 13, 2024
Comment on lines
+40
to
+41
| if auth_config.component != ComponentTypes.nrc: | ||
| auth_config.component = ComponentTypes.nrc |
There was a problem hiding this comment.
From what I understand the component types acronyms are semi-deprecated, but it might not hurt to have a logger.warning here, if the check is actually important, to avoid unexpected surprises.
* add open zaak to docker-compose * use open zaak URL in docker example data * add basic documentation for steps * raise proper exception in step and add test for it
stevenbal
deleted the
feature/200-autorisaties-api-setup-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200