Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[es] feature: demo structure - spanish translation #5053

Merged
merged 20 commits into from
Aug 28, 2024
Merged

[es] feature: demo structure - spanish translation #5053

merged 20 commits into from
Aug 28, 2024

Conversation

krol3
Copy link
Contributor

@krol3 krol3 commented Aug 17, 2024

Related the issue #4887

@krol3 krol3 requested a review from a team August 17, 2024 21:27
@krol3 krol3 mentioned this pull request Aug 17, 2024
Closed
13 tasks
@krol3 krol3 changed the title feature: demo structure - spanish translation [es] feature: demo structure - spanish translation Aug 17, 2024
@theletterf theletterf marked this pull request as draft August 18, 2024 15:56
@krol3 krol3 marked this pull request as ready for review August 22, 2024 17:22
@krol3
Copy link
Contributor Author

krol3 commented Aug 22, 2024

@ramrodo @theletterf @electrocucaracha, could you review please?

ramrodo
ramrodo reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@ramrodo ramrodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions made.

theletterf and others added 6 commits August 23, 2024 07:51
theletterf
theletterf requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Just some comments to better align.

content/es/docs/demo/_index.md Outdated Show resolved Hide resolved
content/es/docs/demo/_index.md Outdated Show resolved Hide resolved
content/es/docs/demo/_index.md Outdated Show resolved Hide resolved
content/es/docs/demo/_index.md Outdated Show resolved Hide resolved
content/es/docs/demo/_index.md Outdated Show resolved Hide resolved
content/es/docs/demo/_index.md Outdated Show resolved Hide resolved
content/es/docs/demo/_index.md Outdated Show resolved Hide resolved
@theletterf
Copy link
Member

@krol3 PTAL, thanks!

electrocucaracha
electrocucaracha reviewed Aug 26, 2024
View reviewed changes
content/es/docs/demo/_index.md Outdated Show resolved Hide resolved
content/es/docs/demo/_index.md Outdated Show resolved Hide resolved
content/es/docs/demo/_index.md Outdated Show resolved Hide resolved
theletterf and others added 3 commits August 27, 2024 09:21
@theletterf @electrocucaracha
Update content/es/docs/demo/_index.md
80ec610 
Co-authored-by: Victor Morales <[email protected]>
@krol3 @theletterf
Update content/es/docs/demo/_index.md
c000434 
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
@krol3 @theletterf
Update content/es/docs/demo/_index.md
0092959 
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
krol3 and others added 6 commits August 27, 2024 16:19
@krol3 @theletterf
Update content/es/docs/demo/_index.md
0ee9919 
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
@krol3 @theletterf
Update content/es/docs/demo/_index.md
7397400 
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
@krol3 @theletterf
Update content/es/docs/demo/_index.md
f6b6a4e 
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
@krol3 @theletterf
Update content/es/docs/demo/_index.md
d9ba1a1 
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
@krol3 @theletterf
Update content/es/docs/demo/_index.md
c45a43b 
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
@theletterf
Update _index.md
295df41
@theletterf
Copy link
Member

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10593094091

@theletterf theletterf added this pull request to the merge queue Aug 28, 2024
Merged via the queue into open-telemetry:main with commit 039286b Aug 28, 2024
17 checks passed
michael2893 pushed a commit to michael2893/opentelemetry.io that referenced this pull request Sep 8, 2024
@krol3 @theletterf
@ramrodo @electrocucaracha @opentelemetrybot
[es] feature: demo structure - spanish translation (open-telemetry#5053)
187e763 
Signed-off-by: carolina valencia <[email protected]>
Co-authored-by: carolina valencia <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Rodolfo Martínez Vega <[email protected]>
Co-authored-by: Victor Morales <[email protected]>
Co-authored-by: opentelemetrybot <[email protected]>
@krol3 krol3 mentioned this pull request Sep 11, 2024
Closed
6 tasks
@krol3 krol3 mentioned this pull request Sep 21, 2024
Open
1 task
@krol3 krol3 deleted the es-demo-folder branch September 21, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramrodo ramrodo ramrodo left review comments

@electrocucaracha electrocucaracha electrocucaracha left review comments

@theletterf theletterf theletterf approved these changes

Assignees
No one assigned
Labels
lang:es
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krol3 @theletterf @opentelemetrybot @electrocucaracha @ramrodo