Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instana exporter documentation. #4346

Closed
wants to merge 1 commit into from

Conversation

kothiga
Copy link

@kothiga kothiga commented Dec 20, 2024

Addition of new Instana exporter environment variables. These changes are related to the following PR that adds an OpenTelemetry exporter for Instana open-telemetry/opentelemetry-php#1462

@kothiga kothiga requested review from a team as code owners December 20, 2024 19:16
Copy link

CLA Not Signed

@@ -233,6 +234,13 @@ _is no specified default, or configuration via environment variables_.
| OTEL_EXPORTER_PROMETHEUS_HOST | Host used by the Prometheus exporter | "localhost" |
| OTEL_EXPORTER_PROMETHEUS_PORT | Port used by the Prometheus exporter | 9464 |

## Instana Exporter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this belongs in the spec. this can be documented in the respective language docs itself.
Spec defined variable are generally applicable more widely, and usually don't have vendor specific things.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Not even in the language docs - the SDKs are not required to implement exporters to specific vendor backends (which for some reason are not willing to accept OTLP?). If there is an exporter somewhere in contrib that's where such documentation would belong.

@reyang
Copy link
Member

reyang commented Dec 20, 2024

Hi @kothiga, thank you for contributing to the OpenTelemetry project!

Please make sure that you clear the CLA #4346 (comment).

Also, as Cijo/Yuri both called out, this specification repository is not the right place to document vendor specific exporter configurations. Consider contributing the change to the vendor specific exporter doc.

@reyang reyang closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants