Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instana exporter implementation. #1462

Closed
wants to merge 1 commit into from

Conversation

kothiga
Copy link

@kothiga kothiga commented Dec 20, 2024

This PR is to contribute an OpenTelemetry exporter which facilitates conversion and transmission of spans to Instana.

I have also opened two other PRs for documentation related to this work

I hope that I have added everything correctly for the read-only git subtree split.

@kothiga kothiga requested a review from a team as a code owner December 20, 2024 19:16
Copy link

welcome bot commented Dec 20, 2024

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

Copy link

linux-foundation-easycla bot commented Dec 20, 2024

CLA Not Signed

@brettmc
Copy link
Collaborator

brettmc commented Dec 21, 2024

Hi @kothiga
The opentelemetry-php repository is for our implementation of the opentelemetry specification, and none of this stuff is in the spec.
Taking a quick look through instana's docs, I see that Instana can seamlessly integrate with OpenTelemetry. Native OTLP support for ingesting telemetry is the direction most if not all APM vendors are moving in, and that's what we're all about here.
So, if Instana already natively supports the OTLP protocol, why is this PR required? And if it is required for some use-cases, wouldn't it be better done in the opentelemetry collector, so that it would work for all languages?

@kothiga
Copy link
Author

kothiga commented Dec 23, 2024

Hi @brettmc!

Just to start off, we have customers that are using our native protocol that we still need to support. Our native protocol tracer supports discovery and autotracing, but there is quite a bit of disparity with Otel PHP on these features as well as frameworks supported.

With this contribution we wanted to provide support for the Otel SDK to natively support proprietary APIs in OpenTelemetry.

wouldn't it be better done in the opentelemetry collector

The idea here was to not have to require our native customers to install additional Otel collectors where they are already installing our native agent.

It is our intention to provide more contributions to OpenTelemetry PHP in the future to close the existing differences.

@brettmc
Copy link
Collaborator

brettmc commented Dec 24, 2024

With this contribution we wanted to provide support for the Otel SDK to natively support proprietary APIs in OpenTelemetry.

Such a change would need to be spec-driven, but as things stand this repo is not the place to host a proprietary exporter.

Your best bet, if you don't want to change your agent to support OpenTelemetry, is to publish and maintain this code in your own repository. You can publish it to packagist, and add it to the registry over on opentelemetry.io.

Instana's documentation is the place to document how to install the proprietary Instana exporter to work with the open-source OpenTelemetry ecosystem.

@brettmc brettmc closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants