Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3688] Update Objects API registration options form #3861

Merged
merged 7 commits into from
Feb 21, 2024
Merged

[#3688] Update Objects API registration options form #3861

merged 7 commits into from
Feb 21, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Feb 9, 2024 •
edited
Loading

Part of #3688.

To be resolved:

@Viicos Viicos linked an issue Feb 9, 2024 that may be closed by this pull request
Objects API registration backend - Improve JSON content field / mapping editor #3688
Closed
33 tasks
@codecov Codecov
Copy link

codecov bot commented Feb 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e34a127) 96.34% compared to head (8360c81) 96.35%.
Report is 31 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3861   +/-   ##
=======================================
  Coverage   96.34%   96.35%           
=======================================
  Files         714      714           
  Lines       22344    22343    -1     
  Branches     2563     2563           
=======================================
+ Hits        21527    21528    +1     
+ Misses        567      565    -2     
  Partials      250      250

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Viicos Viicos marked this pull request as draft February 12, 2024 09:50
@Viicos Viicos force-pushed the feature/3688-phase1-frontend branch from 9bc1db3 to 8b9c659 Compare February 14, 2024 14:28
@Viicos Viicos mentioned this pull request Feb 15, 2024
Merged
@Viicos Viicos marked this pull request as ready for review February 16, 2024 12:59
@Viicos Viicos force-pushed the feature/3688-phase1-frontend branch from b1d3913 to f74bc8e Compare February 16, 2024 13:43
@Viicos
Copy link
Contributor Author

Viicos commented Feb 16, 2024

Of course, f74bc8e was too easy..
Screencast from 16-02-24 15:15:50.webm

@Viicos Viicos force-pushed the feature/3688-phase1-frontend branch from 45726f9 to 19e2b68 Compare February 19, 2024 11:55
@Viicos
Copy link
Contributor Author

Viicos commented Feb 19, 2024

I added test but they are probably meaningless for now as SB is getting crazy when running them I have no idea why

sergei-maertens
sergei-maertens requested changes Feb 19, 2024
View reviewed changes
src/openforms/js/components/admin/form_design/registrations/index.js Outdated
},
},
form: ObjectsApiOptionsForm,
onStepEdit: onStepEdit,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this onStepEdit seems to be coded entirely on the structure of camunda registration options. Looks like zgw-create-zaak has the same issue.

I'd expect some crashes due to undefined not having an property find 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the issue and patched straight to master: fac0afc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily the objects API does not require any changes on step edit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping of variable -> json path will need to be updated accordingly when a form variable is deleted/modified ;)

...orms/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsFormFields.js Outdated Show resolved Hide resolved
...components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsFormFields.stories.js Outdated Show resolved Hide resolved
...components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsFormFields.stories.js Outdated Show resolved Hide resolved
@Viicos Viicos force-pushed the feature/3688-phase1-frontend branch 3 times, most recently from 690ae64 to d9af27e Compare February 19, 2024 16:32
@Viicos
Copy link
Contributor Author

Viicos commented Feb 20, 2024

Wait what how are tests passing

@sergei-maertens sergei-maertens self-requested a review February 21, 2024 08:41
@Viicos
[#3688] Add an explicit Objects API registration form
d60ce88 
Use tabs to separate the legacy and new form
Explicitly define the legacy form
@Viicos
[#3688] Add the V2 form
7a152bc 
Handling the effects when selecting an objecttype/version is hard,
so lots of special casing
@Viicos
[#3688] Add Storybook tests for the form behavior
4a130e6
@Viicos
[#3688] Switch from the JSON Schema form to the explicit one
b2f1450
@Viicos
[#3688] Make translations
9ee405b
@Viicos Viicos force-pushed the feature/3688-phase1-frontend branch from c923bc5 to 9ee405b Compare February 21, 2024 10:34
Viicos
Viicos commented Feb 21, 2024
View reviewed changes
src/openforms/js/compiled-lang/en.json
Comment on lines -3124 to -3129
"aWwaAq": [
{
"type": 0,
"value": "Maximum selected checkboxes"
}
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why these where removed

sergei-maertens
sergei-maertens requested changes Feb 21, 2024
View reviewed changes
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some polishing and then this can be merged.

src/openforms/js/components/admin/form_design/registrations/objectsapi/ObjectTypeSelect.js Outdated Show resolved Hide resolved
src/openforms/js/components/admin/form_design/registrations/objectsapi/ObjectTypeSelect.js Show resolved Hide resolved
...penforms/js/components/admin/form_design/registrations/objectsapi/ObjectTypeVersionSelect.js Show resolved Hide resolved
...penforms/js/components/admin/form_design/registrations/objectsapi/ObjectTypeVersionSelect.js Show resolved Hide resolved
...penforms/js/components/admin/form_design/registrations/objectsapi/ObjectTypeVersionSelect.js Outdated Show resolved Hide resolved
...orms/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsFormFields.js Show resolved Hide resolved
src/openforms/js/components/admin/form_design/registrations/objectsapi/V2ConfigFields.js Outdated Show resolved Hide resolved
@Viicos Viicos merged commit 5187503 into master Feb 21, 2024
27 checks passed
@Viicos Viicos deleted the feature/3688-phase1-frontend branch February 21, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergei-maertens sergei-maertens sergei-maertens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Objects API registration backend - Improve JSON content field / mapping editor
2 participants
@Viicos @sergei-maertens