Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3688] Adapt registration options serializer #3891

Merged
merged 6 commits into from
Feb 20, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Feb 15, 2024

Part of #3688

This is the backend companion of #3861.

This will require validation for the mapping in the future

@Viicos Viicos linked an issue Feb 15, 2024 that may be closed by this pull request
33 tasks
@Viicos Viicos force-pushed the feature/3688-new-serializer branch 2 times, most recently from 0f91e5c to 397409e Compare February 15, 2024 16:58
@Viicos Viicos force-pushed the feature/3688-new-serializer branch from 9c720f1 to ee887f4 Compare February 16, 2024 13:43
@Viicos Viicos force-pushed the feature/3688-new-serializer branch from ee887f4 to 81ba142 Compare February 16, 2024 14:34
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a8b6440) 96.34% compared to head (3557a38) 96.33%.
Report is 14 commits behind head on master.

❗ Current head 3557a38 differs from pull request most recent head 0e0a2b4. Consider uploading reports for the commit 0e0a2b4 to get more accurate results

Files Patch % Lines
...nforms/registrations/contrib/objects_api/config.py 93.10% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3891      +/-   ##
==========================================
- Coverage   96.34%   96.33%   -0.01%     
==========================================
  Files         711      712       +1     
  Lines       22252    22287      +35     
  Branches     2554     2560       +6     
==========================================
+ Hits        21438    21470      +32     
- Misses        566      567       +1     
- Partials      248      250       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Viicos Viicos force-pushed the feature/3688-new-serializer branch from 2a61772 to 3557a38 Compare February 16, 2024 16:08
src/openforms/api/fields.py Outdated Show resolved Hide resolved
src/openforms/formio/api/fields.py Outdated Show resolved Hide resolved
@sergei-maertens sergei-maertens merged commit 0b03161 into master Feb 20, 2024
22 of 24 checks passed
@sergei-maertens sergei-maertens deleted the feature/3688-new-serializer branch February 20, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Objects API registration backend - Improve JSON content field / mapping editor
2 participants