-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Migrate /docs items to website #825
Conversation
✅ Deploy Preview for polite-licorice-3db33c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…o website Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
This reverts commit cd56c7e. Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
this is good to go. Don't know why the |
Some lessons learned here:
Long story short, I think we need to revisit the conditions applied in the PR workflow that enforce these checks for the new website structure. Second, whatever is decided to be necessary could probably just be executed on the Action runner to remove this step from the user. |
Signed-off-by: Adam Gardner <[email protected]>
@Kavindu-Dodan do you have any ideas on how to resolve the above to get this merged? Thanks! |
Signed-off-by: Kavindu Dodanduwa <[email protected]>
I resolved the conflicts. But not sure how to fix the genere docs 🤔 we could disable the checks from build as we have a new website for docs @beeme1mr & @toddbaert any opinion on this ? |
Codecov Report
@@ Coverage Diff @@
## main #825 +/- ##
=======================================
Coverage 72.73% 72.73%
=======================================
Files 28 28
Lines 2857 2857
=======================================
Hits 2078 2078
Misses 683 683
Partials 96 96 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@Kavindu-Dodan can't we just change the location of the generated doc? https://github.com/open-feature/flagd/blob/main/flagd/cmd/doc/main.go#L9 |
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
This should now be all good and ready for a re-review (apart from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this file should be moved to the website. A CONTRIBUTING file has special meeting in GitHub and anyone contributing would expect the content to live there.
- [starts_with](https://github.com/open-feature/flagd/blob/main/docs/configuration/string_comparison_evaluation.md#startswith-evaluation-configuration) | ||
- [ends_with](https://github.com/open-feature/flagd/blob/main/docs/configuration/string_comparison_evaluation.md#endswith-evaluation-configuration) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these also be updated to a relative path?
"fractionalEvaluation": [ | ||
"email", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"fractionalEvaluation": [ | |
"email", | |
"fractional": [ | |
{ "var": "email" }, |
Duplicate of #927 |
This PR
reference
menu item on websitedocs/configuration/configuration.md
to websitedocs/configuration/flagd.md
to websitedocs/configuration/flagd_start.md
to websiteRelated Issues
Follow-up Tasks
How to test