Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Move fractional evaluation pages to website #833

Closed
wants to merge 5 commits into from
Closed

docs: Move fractional evaluation pages to website #833

wants to merge 5 commits into from

Conversation

agardnerIT
Copy link
Contributor

This PR

  • Moves fractional evaluation information to website

@agardnerIT agardnerIT requested a review from a team as a code owner August 14, 2023 00:31
@netlify
Copy link

netlify bot commented Aug 14, 2023

Deploy Preview for polite-licorice-3db33c ready!

Name Link
🔨 Latest commit e5bc867
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/64ec11e23ccbd3000865571c
😎 Deploy Preview https://deploy-preview-833--polite-licorice-3db33c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Adam Gardner <[email protected]>
docs/configuration/fractional_evaluation.md Outdated Show resolved Hide resolved
web-docs/concepts/index.md Outdated Show resolved Hide resolved
agardnerIT and others added 2 commits August 28, 2023 13:12
Co-authored-by: Michael Beemer <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
@beeme1mr
Copy link
Member

@toddbaert @craigpastro, now that we've released the updated fractional evaluation logic, could you please confirm these docs are accurate?

@toddbaert
Copy link
Member

toddbaert commented Aug 31, 2023

@toddbaert @craigpastro, now that we've released the updated fractional evaluation logic, could you please confirm these docs are accurate?

They are not at all accurate because of the conflict. The "old" contents are being moved, and instead the "new" contents should be, I guess, but I'm not sure I fully understand the intent of the move itself; I haven't been keeping up with all of the doc changes here.

@craigpastro
Copy link
Member

All examples and samples are still using the now deprecated fractionalEvaluation key. Should those be updated?

@toddbaert
Copy link
Member

All examples and samples are still using the now deprecated fractionalEvaluation key. Should those be updated?

Ya, basically this "move" should be performed again with the updated content. I dont think any content needs to be changed.

@agardnerIT
Copy link
Contributor Author

Closing in favour of one larger, but easier to review PR: #825

@agardnerIT agardnerIT closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants