Do not hard-code camera frame rate #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the argument parsing to a separate function to reduce complexity of the main function.
Compute camera time series length dynamically to cover the full robot time series window. This is to ensure that for each robot observation in the buffer there is also a camera observation.
Instead of hard-coding it in the script, use the new `get_sensor_info()` method of the driver to get the camera frame rate. The frame rate is specified for each of the three cameras, but since they are syncronised, they are all the same, so we can simply take the value from the first camera in the list.
luator
force-pushed
the
fkloss/camera_settings
branch
from
577243a to
fae465f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the camera frame rate can be configured now, it should not be hard-coded anywhere.
get_sensor_info()of the driver to get its frame rate.Settingsclass to read the settings and get the frame rate from there. Note that this only works as long as the driver is using the default settings discovery and is not passed a file explicitly!How I Tested
By running the two scripts and checking the resulting timeseries/logger buffer sizes when changing the camera frame rate.