Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to latest openapi #4

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Conversation

giulio-opal
Copy link
Contributor

@giulio-opal giulio-opal commented Mar 18, 2024

Could I get a check on this huge update?

Commands run:

cp ../opal/web/backend/router/handlers/public/openapi.yaml api/openapi.yaml
make gen-openapi

Notable changes:

  • add templates for the example part of the readme, so that it doesn't get overriden
  • add template for github workflow to add an ignore of a failing lint that shouldn't fail. I didn't find anything related about that on openapi-generator, so ignoring is the only way forward
  • format all the files with black which is pretty much standard for python (like gofmt)

Evantually I'll set up a github action to automatically release a package on pypi but not in this PR at the moment

To test it do:

pip install git+https://github.com/opalsecurity/opal-python.git@c1d77ff9caf9b85a4c4dec557e3cc986451b412b

Copy link

@amagnus amagnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the example from the Readme locally, looks good!

@aashish-opal
Copy link

@giulio-opal anything else needed to land this PR?

@giulio-opal giulio-opal merged commit cdb305a into main Apr 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants