Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Request.canFulfill() #28

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix Request.canFulfill() #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8278b3
fix Request.canFulfill check
sisyphusSmiling Nov 15, 2024
8528587
Apply suggestions from code review
sisyphusSmiling Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion contracts/RandomConsumer.cdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,13 @@ access(all) contract RandomConsumer {
self.fulfilled = false
}

/// Returns whether the request can be fulfilled as defined by whether it has already been fulfilled and the
/// created block height has been surpassed.
///
/// @param: True if it can be fulfilled, false otherwise
///
access(all) view fun canFullfill(): Bool {
return !self.fulfilled && getCurrentBlock().height >= self.block
return !self.fulfilled && getCurrentBlock().height > self.block
}

/// Returns the Flow's random source for the requested block height
Expand Down
Loading