Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Request.canFulfill() #28

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix Request.canFulfill() #28

merged 2 commits into from
Nov 19, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

Closes: #27

@sisyphusSmiling sisyphusSmiling self-assigned this Nov 15, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review November 15, 2024 22:01
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner November 15, 2024 22:01
@sisyphusSmiling sisyphusSmiling mentioned this pull request Nov 18, 2024
Merged
nvdtf
nvdtf approved these changes Nov 19, 2024
View reviewed changes
contracts/RandomConsumer.cdc Outdated Show resolved Hide resolved
@sisyphusSmiling @nvdtf
Apply suggestions from code review
8528587 
Co-authored-by: Navid TehraniFar <[email protected]>
@sisyphusSmiling sisyphusSmiling merged commit 2668665 into main Nov 19, 2024
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the gio/fix-request-can-fulfill branch November 19, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvdtf nvdtf nvdtf approved these changes

Assignees

@sisyphusSmiling sisyphusSmiling

Labels
Bugfix
Projects
🌊 Flow 4D
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RandomConsumer.Request.canFulfill() returns invalid boolean when getCurrentBlock() == self.block
2 participants
@sisyphusSmiling @nvdtf