-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code submission for FLIP fest 'Playground: Fix client-side errors in the playground frontend #58' - Milestone 1 #176
Conversation
@hichana is attempting to deploy a commit to the Flow Team on Vercel. A member of the Team first needs to authorize it. |
Thanks for the feedback @MaxStalker. I made the revisions:
For now I've marked the comments you left in this thread as 'resolved', but please let me know if these changes don't satisfy your comments in some way and I'll be happy to revise again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! ⭐
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/onflow/flow-playground/6y5ZUUxxkRHRvHteAeKu5kxQSNxB |
Closes: #163 #164 #165 #166
Description
This PR includes work done in PR #167. #167 resolves the main issues that were causing the cascade of console errors. As I wrote in that PR, and as encouraged in the FLIP issue, I refactored the code in order to help avoid similar issues in the future. This refactor was done as a part of FLIP fest issue #58. My basic thinking for this refactor was:
For contributor use:
Files changed
in the Github PR explorer