Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: Fix client-side errors in the playground frontend 58 - Milestone 1 #77

Merged

Conversation

hichana
Copy link
Contributor

@hichana hichana commented Oct 24, 2021

Playground: Fix client-side errors in the playground frontend 58 - Milestone 1

Description

This PR is for issue #58

After investigating the redirect scheme for the playground I implemented a revised method that reduces the redirects in order to reduce the possibility of similar errors experienced in #58 and provide the user with a better/faster experience. I made a guide describing the changes and providing instructions with sample user flows: https://github.com/hichana/flip-fest/tree/submission/issue-%2358/milestone-%231/hichana/submission/issue-58/milestone-1/hichana

Requirements satisfied:

  • "Eliminate each error referenced in the issues above."
  • "When applicable, refactor the code to avoid similar errors in the future."

Submission Links & Documents

  • Readme file with details HERE
  • Code submission PR #176

Requirements Check

  • Have have you met the milestone requirements? Yes
  • Have you included tests (if applicable)? N/A
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? Yes
  • If this is the last milestone:
    • Demonstrate that you've met all the acceptance criteria (link to code, demos, instructions to run etc.). Please see a comprehensive guide I made HERE.
    • Demonstrate that you've met all milestone requirements and highlight any extensions or additional work done.: Please see a comprehensive guide I made HERE.
    • Include a payout structure by percentage for each team member (ie. Bob: 20%, Alice: 80%).: @hichana: 100%

@hichana hichana changed the title Submission/issue #58/milestone #1/hichana Playground: Fix client-side errors in the playground frontend - Milestone 1 Oct 24, 2021
@hichana hichana changed the title Playground: Fix client-side errors in the playground frontend - Milestone 1 Playground: Fix client-side errors in the playground frontend 58 - Milestone 1 Oct 24, 2021
@kerrywei kerrywei requested a review from MaxStalker November 4, 2021 17:08
@MaxStalker
Copy link
Contributor

Congrats, @hichana !
🎉 Milestone Achieved! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants