Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Feature: Add view command - Milestone 1 #52

Closed
wants to merge 2 commits into from
Closed

CLI Feature: Add view command - Milestone 1 #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cea27c6
Submission
gauravmarwal Oct 3, 2021
4027521
Submission
gauravmarwal Oct 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions submissions/issue-26/milestone-1/anuj17026_9261/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
## CLI Feature: Add view command - Milestone 1

## Description

This PR is for issue #26.

- Created CLI view commands for accounts, contracts, deployments, networks, and emulators.
- This command shows the list of all accounts, contracts, deployments, networks, or emulators in the configuration. Eg: flow config view account --> shows a list of all accounts present in the configuration.
- It also shows the properties of a particular entity if we pass it as an argument. Eg: flow config view account accountname --> shows the properties of "accountname"

## Submission Links & Documents
[PR made on flow-cli](https://github.com/onflow/flow-cli/pull/394)

## Requirements Check

- Have have you met the milestone requirements? Yes
- Have you included tests (if applicable)? Yes
- Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? Yes
- If this is the last milestone:
- Demonstrate that you've met all the acceptance criteria (link to code, demos, instructions to run etc.)
Link: Configuration File: [flow.json](https://drive.google.com/file/d/16XFXjFFUCrSw_q7HLBXV7kCF8v4Naz__/view?usp=sharing)
Commands and Results: [Commands and results](https://drive.google.com/file/d/1KDgmfQlXABv-gvit7Rjo52busPQo4Ab2/view?usp=sharing)

## Other Details

- Can you please review that if our solution is up to the mark or not? Also are there any suggestions/reviews to make improvements in our solution?