Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Feature: Add view command - Milestone 1 #52

Closed
wants to merge 2 commits into from

Conversation

gauravmarwal
Copy link

CLI Feature: Add view command - Milestone 1

Description

This PR is for issue #26.

  • Created CLI view commands for accounts, contracts, deployments, networks, and emulators.
  • This command shows the list of all accounts, contracts, deployments, networks, or emulators in the configuration. Eg: flow config view account --> shows a list of all accounts present in the configuration.
  • It also shows the properties of a particular entity if we pass it as an argument. Eg: flow config view account accountname --> shows the properties of "accountname"

Submission Links & Documents

PR made on flow-cli

Requirements Check

  • Have have you met the milestone requirements? Yes
  • Have you included tests (if applicable)? Yes
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? Yes
  • If this is the last milestone:
    • Demonstrate that you've met all the acceptance criteria (link to code, demos, instructions to run etc.)
      Link: Configuration File: flow.json
      Commands and Results: Commands and results

Other Details

  • Can you please review that if our solution is up to the mark or not? Also are there any suggestions/reviews to make improvements in our solution?

@sideninja sideninja self-requested a review October 4, 2021 12:46
Copy link
Contributor

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments on the PR. The design needs to be improved.

@sideninja
Copy link
Contributor

Not active progress

@sideninja sideninja closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants