FCL Feature: Calculate the transaction hash #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avcdsld
requested review from
10thfloor,
chasefleming,
gregsantos,
JeffreyDoyle and
orodio
as code owners
|
Thanks for your contribution @avcdsld! This is looking quite solid overall. 👏 |
gregsantos
suggested changes
Oct 11, 2021
packages/sdk/src/resolve/voucher.js
Outdated
| @@ -54,3 +55,8 @@ export const createSignableVoucher = ix => { | |||
| envelopeSigs: buildOutsideSigners(), | |||
| } | |||
| } | |||
|
|
|||
| export const voucherToTxId = voucher => { | |||
| // ref. https://github.com/onflow/flow-go-sdk/blob/d794a2/transaction.go#L119 | |||
There was a problem hiding this comment.
Thanks @avcdsld We're just aligning internally about any last requests before merge but consider this milestone submission approved!
gregsantos
approved these changes
Oct 13, 2021
orodio
approved these changes
Oct 13, 2021
|
Thanks so much for this @avcdsld and continuing to be an amazing member of the Flow community. |
|
Thank you @avcdsld ! This is an excellent addition to FCL 😄 |
|
Merged into master @avcdsld 🚀 Thank you for your contribution and support! |
|
Thanks @avcdsld ! Great contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
Description
(Partial copy from FLIP Fest issue 24)
Right now, there's no way to get the transaction hash before it's sent to the blockchain. Pre-calculating the transaction hash will allow for error recovery if there are any network connection issues during the submission of the transaction.
Features
Other
This is features addition to
@onflow/sdk. After the@onflow/sdkversion is upgraded, the following changes to fcl will make it available to fcl. This is a very trivial change.packages/fcl/src/fcl.js