Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCL Feature: Calculate the transaction hash - Milestone 1 #57

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

avcdsld
Copy link
Contributor

@avcdsld avcdsld commented Oct 8, 2021

FCL Feature: Calculate the transaction hash - Milestone 1

Description

This PR is for issue #24 (#24)

Submission Links & Documents

onflow/fcl-js#840

Requirements Check

  • Have have you met the milestone requirements? YES
  • Have you included tests (if applicable)? YES
  • Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? YES
  • If this is the last milestone: YES
    • payout @avcdsld 100% (There are three of us on the team, but I'm the only one participating in this issue.)

Other Details

  • Is there anything specific you'd like the PoC to know or review for? NO
  • Are there other references, documentation, or relevant artificats to mention for this PR (ie. external links to justify design decisions, etc.)? NO

@psiemens psiemens requested a review from gregsantos October 11, 2021 05:53
@gregsantos
Copy link

Thanks for your contribution @avcdsld! This is looking quite solid overall. 👏
We will have a chance to run, test, and review soon and should have any feedback to you early this week.

Copy link

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review started at onflow/fcl-js#840

@srinjoyc srinjoyc merged commit 6f78234 into onflow:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants