Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e/eoa): add new role RoleXCaller #2379

Merged
merged 7 commits into from
Nov 5, 2024
Merged

Conversation

kc1116
Copy link
Contributor

@kc1116 kc1116 commented Nov 4, 2024

This PR adds a new role RoleXCaller that will be used to send xmsgs on differen't networks and source chain/dest chain combinations. We will create a github action that will periodically send xmsgs and it will use this account.

issue: #2275

- update thresholds
- update sane min/max
@@ -41,6 +41,8 @@ const (
RoleUpgrader Role = "upgrader"
// RoleTester is used for general tasks and testing in non-mainnet networks.
RoleTester Role = "tester"
// RoleXCaller is used for sending xmgs on a network.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// RoleXCaller is used for testing xcalls on a network.

Comment on lines 40 to 43
thresholdSmall = FundThresholds{
minGwei: gwei(0.35),
targetGwei: gwei(.6),
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets make it round numbers (20x tiny), suggest: min: 0.02, target: 0.2.

@corverroos corverroos changed the title chore(e2e): add new role RoleXCaller chore(e2e/eoa): add new role RoleXCaller Nov 5, 2024
@kc1116 kc1116 merged commit 83a5745 into main Nov 5, 2024
19 checks passed
@kc1116 kc1116 deleted the khalil/mainnet-role-xcaller branch November 5, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants