chore(e2e/eoa): add new role RoleXCaller #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kc1116
requested review from
corverroos,
sideninja,
chmllr and
kevinhalliday
as code owners
- update thresholds - update sane min/max
corverroos
approved these changes
Nov 5, 2024
e2e/app/eoa/eoa.go
Outdated
| @@ -41,6 +41,8 @@ const ( | |||
| RoleUpgrader Role = "upgrader" | |||
| // RoleTester is used for general tasks and testing in non-mainnet networks. | |||
| RoleTester Role = "tester" | |||
| // RoleXCaller is used for sending xmgs on a network. | |||
There was a problem hiding this comment.
// RoleXCaller is used for testing xcalls on a network.
e2e/app/eoa/fund.go
Outdated
Comment on lines
40
to
43
| thresholdSmall = FundThresholds{ | ||
| minGwei: gwei(0.35), | ||
| targetGwei: gwei(.6), | ||
| } |
There was a problem hiding this comment.
lets make it round numbers (20x tiny), suggest: min: 0.02, target: 0.2.
sideninja
approved these changes
Nov 5, 2024
corverroos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new role RoleXCaller that will be used to send xmsgs on differen't networks and source chain/dest chain combinations. We will create a github action that will periodically send xmsgs and it will use this account.
issue: #2275