chore(e2e): add new role RoleXCaller #2365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kc1116
requested review from
corverroos,
sideninja,
chmllr and
kevinhalliday
as code owners
corverroos
changed the title
kc1116
changed the title
corverroos
requested changes
Nov 4, 2024
| "min": "2.0080", | ||
| "target": "8.0800" | ||
| "min": "22.0080", | ||
| "target": "108.0800" |
There was a problem hiding this comment.
these thresholds are too high for mainnet
There was a problem hiding this comment.
I think threshold for tester has to be decreased on mainnet, possibly we can do a dynamic overwrite of the threshold, see something similar here:
Line 74 in 16feed3
sideninja
reviewed
Nov 4, 2024
e2e/app/eoa/static.go
Outdated
| @@ -46,5 +46,6 @@ var statics = map[netconf.ID][]Account{ | |||
| remote("0x9496Bf1Bd2Fa5BCba72062cC781cC97eA6930A13", RoleDeployer), | |||
| secret("0xfD62020Cee216Dc543E29752058Ee9f60f7D9Ff9", RoleMonitor), | |||
| secret("0x6191442101086253A636aecBCC870e4778490AaB", RoleRelayer), | |||
| secret("0xE7069f1C1E9477bA69B4d46D015a96509c59263c", RoleTester), | |||
There was a problem hiding this comment.
why are we adding this account as secret not as remote?
- update thresholds golden file
kc1116
changed the title
|
Closed for #2379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new role RoleXCaller that will be used to send xmsgs on differen't networks and source chain/dest chain combinations. We will create a github action that will periodically send xmsgs and it will use this account.
issue: #2275