Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflow fixes (Gradle, outdated actions) #106

Merged
merged 6 commits into from
Mar 7, 2023

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Mar 6, 2023

Primarily addresses the fact that the GitHub workflow now installs Gradle 8 by default which is incompatible with build.gradle - see https://github.com/ome/bio-formats-examples/actions/runs/4333848395

This PR contains an assortment of CI improvements:

  • pins the Gradle version to be used to 7.6
  • upgrades the Java setup to use actions/setup-java@v3
  • upgrades the checkout to use actions/setup-java@v3
  • add JDK 17 to the testing matrix since this repository consumes Bio-Formats 6.12+

@sbesson sbesson requested a review from jburel March 6, 2023 11:58
@sbesson sbesson mentioned this pull request Mar 6, 2023
@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build BIOFORMATS-push#401. See the console output for more details.
Possible conflicts:

--conflicts

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build BIOFORMATS-push#1553. See the console output for more details.
Possible conflicts:

--conflicts

Copy link
Member

@jburel jburel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

@sbesson sbesson merged commit a045d97 into ome:master Mar 7, 2023
@sbesson sbesson deleted the gradle_workflow_fixes branch March 7, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants