Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete fixed costs parameter for GenericCAES initialization #995

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Remove obsolete fixed costs parameter for GenericCAES initialization #995

merged 1 commit into from
Oct 18, 2023

Conversation

jokochems
Copy link
Member

Remove the obsolete fixed_costs parameter for instances of the GenericCAES which does not (resp. no longer?) support it.

Closes #994

@jokochems jokochems self-assigned this Oct 13, 2023
@jokochems jokochems linked an issue Oct 13, 2023 that may be closed by this pull request
Generic CAES unit examples have unused fixed_costs parameter #994
Closed
@jokochems jokochems changed the title Remove obsolete fixed costs parameter Remove obsolete fixed costs parameter for GenericCAES initialization Oct 13, 2023
@jokochems jokochems requested a review from p-snft October 14, 2023 09:46
p-snft
p-snft approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@p-snft p-snft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to remove it for consistency. I will merge.

@p-snft p-snft merged commit b5b098a into dev Oct 18, 2023
11 of 12 checks passed
@p-snft p-snft deleted the fix/generic-caes-unused-fixed_costs-parameter branch October 18, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-snft p-snft p-snft approved these changes

Assignees

@jokochems jokochems

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic CAES unit examples have unused fixed_costs parameter
2 participants
@jokochems @p-snft