Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic CAES unit examples have unused fixed_costs parameter #994

Closed
jokochems opened this issue Oct 13, 2023 · 0 comments · Fixed by #995
Closed

Generic CAES unit examples have unused fixed_costs parameter #994

jokochems opened this issue Oct 13, 2023 · 0 comments · Fixed by #995
Assignees
@jokochems

Comments

@jokochems
Copy link
Member

jokochems commented Oct 13, 2023 •
edited
Loading

Problem description

In the process of fixing the handling of fixed_costs for multi-period models, I detected that in the example usages, a fixed_costs parameter is declared for the constructor method. I assume this is due to historical reasons, but it has no effect and is just silently ignored.

Suggestion

My suggestion would be to simply remove it. Since it is a very quick fix, I'll open a PR shortly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jokochems jokochems

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove obsolete fixed costs parameter for GenericCAES initialization oemof/oemof-solph
1 participant
@jokochems