Remove internal discounting functionality #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Offsetting the objective value for models with just one period won't hurt anybody. So, harmonisation is obviously not a loss.
This also changes the result of "test_multi_period_dispatch_model". As this model is too complex for a unit test, I switched it off for now. Signed-off-by: Patrik Schönfeldt <[email protected]>
# Conflicts: # src/oemof/solph/components/_generic_storage.py # src/oemof/solph/flows/_simple_flow_block.py
The (very similar) interest still needs to be removed.
|
This removal was agreed on. As stated above, this just externalizes complexity and does not remove functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discounting functionality is not actually needed, as we allow time series anyway. So, we can remove code without reducing functionality.