-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove discounting from the multi-period model #1109
Comments
The merged branch was not finalised. Continues in #1111. |
For the discussion how we implement this in a new way, we came from the problem formulation (how would that be maintainable) and still need to define the API details. The current API only allows scalars, I'd change this: Investment(
maximum=inf, # maximum_addition=list()
minimum=0, # minimum_addition=list()
ep_costs=0, # we directly take the numbers from this sequence
existing=0, # superseded by minimum_capacity[0]
nonconvex=False,
offset=0,
overall_maximum=None, # replace by maximum_capacity=list()
overall_minimum=None, # replace by minimum_capacity=list()
lifetime=None, # list (in periods)
age=0, # not needed anymore
interest_rate=0, # not needed anymore
fixed_costs=None, # not needed anymore
custom_attributes=None,
) For the lifetime, What do you think? (Also asking @mco-sch, who has used the feature in the current shape.) |
I like the suggestions. Thank you very much! |
Discounting functionality is not actually needed, as we allow time series anyway. So, we can remove code without reducing functionality. (Users should be able to calculate discounting externally. On the long run, we could also provide something in oemof.tools.)
At the user/dev meeting in Oldenburg, we agreed to go one step further. Investments should accept a time series of periodical costs for the investments. Changing capacities can be constrained using constraints linking the years, e.g. “capacity of this investment needs to be constant for fifteen years”.
The text was updated successfully, but these errors were encountered: