Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: improve the camera calibration toolbox, SIFT implementation #389

Merged
merged 15 commits into from
Jun 7, 2024
Merged

ENH: improve the camera calibration toolbox, SIFT implementation #389

merged 15 commits into from
Jun 7, 2024

Conversation

oddkiva
Copy link
Owner

@oddkiva oddkiva commented Jun 6, 2024

Among others, here are the most important improvements:

  • Fixed and robustified the camera calibration toolbox:
    • mostly because of the poor initialization of the extrinsic parameters
    • Calibration of the intrinsic camera parameters works really well.
    • Tested with the ideal pinhole camera model and the omnidirectional camera model.
    • Added a small database of camera models with their intrinsic parameters.
  • Fixed the SIFT implementation
    • discard DoG extrema with estimated scales that are enormous and, as such they are implausible.

oddkiva and others added 15 commits May 30, 2024 15:20
@oddkiva
WIP: add trackball.
66d9160
@oddkiva
BUG: we must discard the DoG with implausible refined scale.
36da75a 
The refined scale is implausible if it is way too far from the
approximate scale at which the DoG has been detected.
DOC: add note about the planar configuration which the DLT cannot solve.
c013fe3
MAINT: simplify (and accelerate) the point cloud render.
903c0a7
MAINT: clean up code.
487995e
MAINT: remove draft affine adaptation code.
3d63805
ENH: improve the initialization of extrinsic parameter with a P3P sol…
fb54943 
…ver.
MAINT: clean up code.
92e54ee
MAINT: eliminate hard-coded value.
6d407d1
MAINT: review calibration code.
3bb60aa
Merge branch 'master' into enh-improve-user-interaction
1691c13
@oddkiva
MAINT: fix compile error.
1ac765b
@oddkiva
ENH: improve the calibration of omnidirectional cameras.
eb4c773
@oddkiva
ENH: improve the initialization method of the extrinsic parameters.
cc01581 
My homography decomposition methods were implemented in a dodgy manner
and without any real understanding of the maths. I simply replaced them
with the robust P3P solver that we have at our disposal (Lambda-Twist).
@oddkiva
ENH: add calibration parameters for consumer fisheye cameras.
5443c72 
- GOPRO 7 Hero Black, Superview mode
- Insta ONE RS 360
@oddkiva oddkiva self-assigned this Jun 6, 2024
@oddkiva oddkiva merged commit b418868 into master Jun 7, 2024
4 checks passed
@oddkiva oddkiva deleted the enh-improve-user-interaction branch June 7, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oddkiva oddkiva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oddkiva