Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror the target control of ObjectNavFragment if front facing camera is used #386

Merged

Conversation

yijunwu
Copy link
Contributor

@yijunwu yijunwu commented Dec 6, 2023

When front facing camera is used, the target control of ObjectNavFragment should be mirrored otherwise the bot can't follow the target object. See the issue 385 for detail

@thias15
Copy link
Collaborator

thias15 commented Dec 12, 2023

The convention for the front camera varies across phones. How about adding an icon to mirror controls next to the camera flip icon.

@yijunwu
Copy link
Contributor Author

yijunwu commented Dec 14, 2023

OK, I haven't tried phones other than Samsung's. Maybe a better solution would be to detect the convention for the phone automatically, and set default value accordingly, in addition to adding icon to mirror control? Not sure if it's detectable. Before figuring out that, adding icon to mirror control can be a basic solution. I'll add some more commits soon

…con to mirror controls next to the camera flip icon, instead of always mirroring control when using front camera.
@yijunwu
Copy link
Contributor Author

yijunwu commented Dec 16, 2023

I've added more commits. It should be ok now.
image
image

@yijunwu
Copy link
Contributor Author

yijunwu commented Dec 16, 2023

I adjusted the layout and appearance of icons, now it looks like this:
6830d259c0e1cca88ef2e2368520496
fa1deaea6ead352cafed02663e759dd

Copy link

@desy0305 desy0305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok excellent update

@sparsh3dwe sparsh3dwe merged commit 4be9151 into ob-f:master Dec 28, 2023
1 check passed
@hardikgarg02
Copy link
Contributor

I have fixed the UI for the fragment. Could you review and replace below file named fragment_object_nav.xml in the path robot/src/main/res/layout-land directory.
fragment_object_nav.xml.zip

And also replace below file named fragment_object_nav.xml in the path robot/src/main/res/layout directory.
fragment_object_nav.xml.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants