-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror the target control of ObjectNavFragment if front facing camera is used #386
Mirror the target control of ObjectNavFragment if front facing camera is used #386
Conversation
The convention for the front camera varies across phones. How about adding an icon to mirror controls next to the camera flip icon. |
OK, I haven't tried phones other than Samsung's. Maybe a better solution would be to detect the convention for the phone automatically, and set default value accordingly, in addition to adding icon to mirror control? Not sure if it's detectable. Before figuring out that, adding icon to mirror control can be a basic solution. I'll add some more commits soon |
…con to mirror controls next to the camera flip icon, instead of always mirroring control when using front camera.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok excellent update
I have fixed the UI for the fragment. Could you review and replace below file named And also replace below file named |
When front facing camera is used, the target control of ObjectNavFragment should be mirrored otherwise the bot can't follow the target object. See the issue 385 for detail