Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectNavSegment control result should be mirrored when using front facing camera #385

Closed
yijunwu opened this issue Dec 6, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@yijunwu
Copy link
Contributor

yijunwu commented Dec 6, 2023

Description
Currently, in ObjectNavSegment, when using front facing camera of the phone, the vehicle's target control is incorrect. When the object is at the vehicle's left front, it turns to right, and vice versa. Currently, in order for the bot to do object nav correctly, one has to put the phone upside down, but consequently the controling UI is upside down too, which is inconvienient to use.

To Reproduce
Steps to reproduce the behavior:

  1. With current release 0.7.1, let the phone screen facing to vehicle's front, and switch to front facing camera
  2. Go to Object Tracking segment
  3. Try object tracking
  4. See error - control should be mirrored

Expected behavior
When the phone screen facing to vehicle's front, and using front facing camera, control target should be correct so that the bot can follow detected object.

Smartphone:

  • Device: some main stream phones, Samsung S20FE & Samsung A40S tested
  • OS: Android 10 & Android 13 tested
  • Version 0.7.1, master

Suggested fix
Fix should be easy, I'll create a pull request soon

@yijunwu
Copy link
Contributor Author

yijunwu commented Dec 6, 2023

I've created a pull request (386) to fix this issue. I've tested the fix and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants