Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HE: Filter IP addresses based on 'ipv6_deployment' #560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tinez
Copy link
Member

@tinez tinez commented Jul 11, 2022

At the beginning of HE deployment we set the 'ipv6_deployment' fact
based on host's address. This var should be the source of truth for
whether to use an IPv4 or IPv6 address for the HE VM.

Until now we were simply picking up the first address that was reported
by 'virsh' and using this throughout the rest of the process.

This PR adds filtering of the reported addresses based on the value of
'ipv6_deployment'. Additionally we're picking the first address to make
other usages of 'local_vm_ip' nicer.

Signed-off-by: Marcin Sobczyk [email protected]

@tinez tinez requested a review from arachmani as a code owner July 11, 2022 15:14
At the beginning of HE deployment we set the 'ipv6_deployment' fact
based on host's address. This var should be the source of truth for
whether to use an IPv4 or IPv6 address for the HE VM.

Until now we were simply picking up the first address that was reported
by 'virsh' and using this throughout the rest of the process.

This PR adds filtering of the reported addresses based on the value of
'ipv6_deployment'. Additionally we're picking the first address to make
other usages of 'local_vm_ip' nicer.

Signed-off-by: Marcin Sobczyk <[email protected]>
@tinez
Copy link
Member Author

tinez commented Jul 11, 2022

/ost he-basic-suite-master el9stream

var: local_vm_ip_candidates
- name: Select first IPv6 address
ansible.builtin.set_fact:
local_vm_ip: "{{ local_vm_ip_candidates.stdout_lines | ansible.netcommon.ipv6 | first }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ansible.netcommon, is this a new collection?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, no, we already depend on it. Thouhg it looks unused until now

@michalskrivanek
Copy link
Member

/ost he-basic-suite-master el8stream

@michalskrivanek
Copy link
Member

it seems it's broken on el8stream too now

@michalskrivanek
Copy link
Member

it seems to me that due to the now-functional ipv4 dhcp entry the vm boots with default route on ipv4, which breaks the assumption and route manipulation of he setup

@michalskrivanek
Copy link
Member

Same problem happens for IPv4-only deployment. Somehow the bootstrap VM enables and gets IPv6 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants