Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python-netaddr dependency #826

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

michalskrivanek
Copy link
Member

it's nothing but a headache to keep up with ansible's idea of bumping
python every few months. Let's drop it entirely.

Fixes issue # (delete if not relevant)

Changes introduced with this PR

Are you the owner of the code you are sending in, or do you have permission of the owner?

[y/n]

it's nothing but a headache to keep up with ansible's idea of bumping
python every few months. Let's drop it entirely.
@mwperina
Copy link
Member

This is just a half of the fix, netaddr is used also in the collection:

[mperina@mperina:~/projects/ovirt/collection]$ git grep ipaddr
plugins/filter/ovirtvmip.py:            ipaddr = int(''.join(['%02x' % int(x) for x in ip.split('.')]), 16)
plugins/filter/ovirtvmip.py:            return (ipaddr & mask) == (netaddr & mask)
roles/hosted_engine_setup/tasks/bootstrap_local_vm/01_prepare_routing_rules.yml:        selectattr('src', 'equalto', virbr_cidr_ipv4 | ipaddr('address') ) |
roles/hosted_engine_setup/tasks/bootstrap_local_vm/01_prepare_routing_rules.yml:        selectattr('dst', 'equalto', virbr_cidr_ipv4 | ipaddr('address') ) |
roles/hosted_engine_setup/tasks/fetch_host_ip.yml:          hostname_resolution_output.stdout.split() | ipaddr |
roles/hosted_engine_setup/tasks/fetch_host_ip.yml:              ipaddr('link-local')

@mwperina mwperina requested a review from mnecas March 23, 2023 09:59
@michalskrivanek
Copy link
Member Author

@michalskrivanek
Copy link
Member Author

basic suite should be enough to test this

@michalskrivanek
Copy link
Member Author

/ost

@michalskrivanek
Copy link
Member Author

host deploy passed, so I think it's good
other deps are of course still needed for disk upload, but it should be ok to drop netaddr

@michalskrivanek
Copy link
Member Author

/ost basic-suite-master el9stream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants