-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python-netaddr dependency #826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's nothing but a headache to keep up with ansible's idea of bumping python every few months. Let's drop it entirely.
michalskrivanek
requested review from
mwperina,
didib and
sandrobonazzola
as code owners
March 23, 2023 08:51
almusil
approved these changes
Mar 23, 2023
This is just a half of the fix, netaddr is used also in the collection:
|
basic suite should be enough to test this |
/ost |
host deploy passed, so I think it's good |
/ost basic-suite-master el9stream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's nothing but a headache to keep up with ansible's idea of bumping
python every few months. Let's drop it entirely.
Fixes issue # (delete if not relevant)
Changes introduced with this PR
Are you the owner of the code you are sending in, or do you have permission of the owner?
[y/n]