Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picks stabilization -> development #773

Merged
merged 10 commits into from
Oct 16, 2024

Conversation

jhanca-robotecai
Copy link
Contributor

What does this PR do?

This PR cherry-picks the changes that were pushed to the stabilization/2409 branch as fixes but not to the development branch.

List of the PRs pushed to the stabilization/2409 branch after the split from the development branch that were added to this PR:

List of the PRs pushed to the stabilization/2409 branch after the split from the development branch that were NOT added to this PR:

@spham-amzn Could you please confirm which version should be set for ROS 2 Gem?

How was this PR tested?

Only 4 PRs were pushed to the development branch after the split and not cherry-picked to the stabilization/2409 branch.

These were cherry-picked back from development to a test branch on top of the stabilization/2409 branch, available https://github.com/RobotecAI/o3de-extras/tree/jh/cherries_dev_stab

The differences from merge conflicts were solved manually making the two branches perfectly equivalent. There is an empty result for the command:

git diff jh/cherries_dev_stab jh/cherries_stab_dev

spham-amzn and others added 10 commits October 11, 2024 16:31
Signed-off-by: Michał Pełka <[email protected]>
Signed-off-by: Jan Hanca <[email protected]>
* Update levels in RoboticManipulationTemplate
* Update Ros2ProjectTemplate for ROS2 Jazzy
* Update Ros2FleetRobotTemplate for ROS2 Jazzy
* Update Dockerfile in Ros2ProjectTemplate

Signed-off-by: Jan Hanca <[email protected]>
* Update custom namespace handling that was triggering overrides for each ROS2FrameComponent in a prefab

Signed-off-by: Artur Kamieniecki <[email protected]>
Signed-off-by: Jan Hanca <[email protected]>
Co-authored-by: Jan Hanca <[email protected]>
Signed-off-by: Jan Hanca <[email protected]>
Signed-off-by: Artur Kamieniecki <[email protected]>
Co-authored-by: Artur Kamieniecki <[email protected]>
Signed-off-by: Jan Hanca <[email protected]>
* Update repo.json for updates for release 2409
* Fix ROS2FleetRobotTemplate errors for wrong ROS distro examples
* Update ROS2FleetRobotTemplate version
* Update last_updated date
* Fix ros2 gem version
* Fix ros2 package hash

Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Jan Hanca <[email protected]>
* Fix hash for ROS2 Project template
* Version bump for the ROS2 Project Template
* Fix hashes and versioning for OpenXRTest and Multiplayer template
* Regenerated Multiplayer template for repo.json

Signed-off-by: Steve Pham <[email protected]>
Signed-off-by: Jan Hanca <[email protected]>
Signed-off-by: Jan Hanca <[email protected]>
@spham-amzn
Copy link
Contributor

@jhanca-robotecai The ROS2 Gem version should be bumped after this cherry-pick so that it will represent the current development version, since 3.2.1 has been released as an official package. sig-release will need to decide how we handle versioning of o3de-extras since its possible to use either github or the release packages from Project Manager. I would expect that with a x.y.z format of the version, 'z' represents a patch, 'y' a minor version update, and 'z' a major version update. In this case, it would make sense to bump the minor version update in development.

@byrcolin byrcolin added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 15, 2024
@jhanca-robotecai jhanca-robotecai merged commit 74920bc into o3de:development Oct 16, 2024
2 checks passed
@jhanca-robotecai jhanca-robotecai deleted the jh/cherries_stab_dev branch October 16, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants