Simplify and improve lidar range configuration #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksander Kamiński <[email protected]>
jhanca-robotecai
added
the
sig/simulation
Signed-off-by: Aleksander Kamiński <[email protected]>
PawelLiberadzki
approved these changes
Aug 8, 2024
adamdbrw
reviewed
Aug 12, 2024
Co-authored-by: Adam Dąbrowski <[email protected]> Signed-off-by: Aleksander Kamiński <[email protected]>
adamdbrw
approved these changes
Aug 12, 2024
jhanca-robotecai
approved these changes
Aug 13, 2024
michalpelka
approved these changes
Aug 13, 2024
alek-kam-robotec-ai
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Aleksander Kamiński <[email protected]> Signed-off-by: Aleksander Kamiński <[email protected]> Co-authored-by: Adam Dąbrowski <[email protected]>
jhanca-robotecai
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Oct 11, 2024
Signed-off-by: Aleksander Kamiński <[email protected]> Signed-off-by: Aleksander Kamiński <[email protected]> Co-authored-by: Adam Dąbrowski <[email protected]>
jhanca-robotecai
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Nov 22, 2024
Signed-off-by: Aleksander Kamiński <[email protected]> Signed-off-by: Aleksander Kamiński <[email protected]> Co-authored-by: Adam Dąbrowski <[email protected]>
jhanca-robotecai
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Nov 25, 2024
Signed-off-by: Aleksander Kamiński <[email protected]> Signed-off-by: Aleksander Kamiński <[email protected]> Co-authored-by: Adam Dąbrowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR simplifies
LidarRaycasterrange configuration (in preparation for #736). It also adds proper, editor-side range value validation.This PR was developed alongside RobotecAI/o3de-rgl-gem#40.
How was this PR tested?
This pull request was tested in a simple test project under various lidar configurations.