Setting k to 50 in the scripts.

Signed-off-by: jzonthemtn <[email protected]>
o19s · Dec 12, 2024 · e8de8ec · e8de8ec
1 parent 57a530c
commit e8de8ec
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/opensearch-search-quality-evaluation-plugin/scripts/create-judgments-now.sh b/opensearch-search-quality-evaluation-plugin/scripts/create-judgments-now.sh
@@ -4,4 +4,4 @@ echo "Deleting existing judgments index..."
 curl -s -X DELETE http://localhost:9200/judgments
 
 echo "Creating judgments..."
-curl -s -X POST "http://localhost:9200/_plugins/search_quality_eval/judgments?click_model=coec&max_rank=10"
+curl -s -X POST "http://localhost:9200/_plugins/search_quality_eval/judgments?click_model=coec&max_rank=50"
diff --git a/opensearch-search-quality-evaluation-plugin/scripts/run-query-set.sh b/opensearch-search-quality-evaluation-plugin/scripts/run-query-set.sh
@@ -1,10 +1,10 @@
 #!/bin/bash -e
 
-QUERY_SET_ID="dcbf3db4-56ea-47cd-87ea-3d13d067ae7a"
-JUDGMENTS_ID="78f0e4e4-1cbf-47b4-9737-5feef65dad4d"
+QUERY_SET_ID="09fc2a69-9bc0-49ea-9747-aefd66528858"
+JUDGMENTS_ID="cd7b72c9-21fa-4500-abf3-722438ab3ad4"
 INDEX="ecommerce"
 ID_FIELD="asin"
-K="10"
+K="50"
 THRESHOLD="1.0" # Default value
 
 curl -s -X DELETE "http://localhost:9200/sqe_metrics_sample_data"

diff --git a/...on-plugin/src/main/java/org/opensearch/eval/judgments/clickmodel/coec/CoecClickModel.java b/...on-plugin/src/main/java/org/opensearch/eval/judgments/clickmodel/coec/CoecClickModel.java
@@ -90,7 +90,7 @@ public String calculateJudgments() throws Exception {
 
         // Calculate and index the click-through rate for query/doc pairs.
         LOGGER.info("Beginning calculation of clickthrough rates.");
-        final Map<String, Set<ClickthroughRate>> clickthroughRates = getClickthroughRate(maxRank);
+        final Map<String, Set<ClickthroughRate>> clickthroughRates = getClickthroughRate();
         LOGGER.info("Clickthrough rates for number of queries: {}", clickthroughRates.size());
         showClickthroughRates(clickthroughRates);
 
@@ -175,11 +175,10 @@ public String calculateCoec(final Map<Integer, Double> rankAggregatedClickThroug
 
     /**
      * Gets the clickthrough rates for each query and its results.
-     * @param maxRank The maximum rank position to consider.
      * @return A map of user_query to the clickthrough rate for each query result.
      * @throws IOException Thrown when a problem accessing OpenSearch.
      */
-    private Map<String, Set<ClickthroughRate>> getClickthroughRate(final int maxRank) throws Exception {
+    private Map<String, Set<ClickthroughRate>> getClickthroughRate() throws Exception {
 
         // For each query:
         // - Get each document returned in that query (in the QueryResponse object).
@@ -205,7 +204,7 @@ private Map<String, Set<ClickthroughRate>> getClickthroughRate(final int maxRank
                 "                    {\n" +
                 "                      \"range\": {\n" +
                 "                        \"event_attributes.position.ordinal\": {\n" +
-                "                          \"lte\": " + maxRank + "\n" +
+                "                          \"lte\": " + parameters.getMaxRank() + "\n" +
                 "                        }\n" +
                 "                      }\n" +
                 "                    }\n" +