Changing to less than rank.

Signed-off-by: jzonthemtn <[email protected]>
o19s · Dec 12, 2024 · 57a530c · 57a530c
1 parent c7691e7
commit 57a530c
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/...on-plugin/src/main/java/org/opensearch/eval/judgments/clickmodel/coec/CoecClickModel.java b/...on-plugin/src/main/java/org/opensearch/eval/judgments/clickmodel/coec/CoecClickModel.java
@@ -356,8 +356,7 @@ public Map<Integer, Double> getRankAggregatedClickThrough() throws Exception {
 
         }
 
-        // TODO: Should this be LTE or just LT? Is rank zero-based?
-        for(int rank = 0; rank <= parameters.getMaxRank(); rank++) {
+        for(int rank = 0; rank < parameters.getMaxRank(); rank++) {
 
             if(impressionCounts.containsKey(rank)) {