Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Go version in GitHub workflows #78

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Fix Go version in GitHub workflows #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
380af80
.github: Fix Go version in `build_cli` job
tatiana-nspcc Feb 29, 2024
5411193
.github: Use Go version from `go.mod` in `lint` job
tatiana-nspcc Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version-file: 'go.mod'
go-version: '1.22'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is strange to me. xk6 is not a library, i do not expect it to be used by anybody. mb just have 1.21 in go mod? it is still supported and usually, such a version will have been tested for 6 month+
@roman-khimov

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or not

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We build binaries with the latest and greatest unless there is a reason to not do so. This PR just fixes an error made in #77 in fact.

cache: true

- name: Update Go modules
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ jobs:
- name: Check out code
uses: actions/checkout@v4

- name: Set up Go from go.mod
uses: actions/setup-go@v5
with:
go-version-file: 'go.mod'

- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
Expand Down
Loading