Fix Go version in GitHub workflows #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we need builds to use the latest and greatest Go. Signed-off-by: Tatiana Nesterenko <[email protected]>
Linter should be set up for the minimum supported version, otherwise, it can report some bugs that aren't relevant for the current Go version. Signed-off-by: Tatiana Nesterenko <[email protected]>
roman-khimov
approved these changes
Feb 29, 2024
carpawell
reviewed
Feb 29, 2024
| @@ -32,7 +32,7 @@ jobs: | |||
| - name: Set up Go | |||
| uses: actions/setup-go@v5 | |||
| with: | |||
| go-version-file: 'go.mod' | |||
| go-version: '1.22' | |||
There was a problem hiding this comment.
that is strange to me. xk6 is not a library, i do not expect it to be used by anybody. mb just have 1.21 in go mod? it is still supported and usually, such a version will have been tested for 6 month+
@roman-khimov
There was a problem hiding this comment.
We build binaries with the latest and greatest unless there is a reason to not do so. This PR just fixes an error made in #77 in fact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #77 and #76.