eacl: Support numeric matchers #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
requested review from
roman-khimov,
smallhive and
carpawell
as code owners
cthulhu-rider
force-pushed
the
feature/eacl-numeric-ops
branch
from
29dafb3 to
ce9130f
Compare
carpawell
reviewed
Feb 14, 2024
|
Yeah, i saw them, i meant what do we do for now? Just ignore them? Maybe at least skip them? |
cthulhu-rider
force-pushed
the
feature/eacl-numeric-ops
branch
from
ce9130f to
84bb77c
Compare
|
forgot to test |
cthulhu-rider
force-pushed
the
feature/eacl-numeric-ops
branch
2 times, most recently
from
d09a4b0 to
a1444d8
Compare
3 tasks
Merged
cthulhu-rider
force-pushed
the
feature/eacl-numeric-ops
branch
from
a1444d8 to
ac151c2
Compare
carpawell
approved these changes
Feb 21, 2024
|
We'll have nspcc-dev/neofs-api#262 soon, we need it. We can discuss per-attribute limits there as well, but those would be like 4K which is not that far from 32K. |
NeoFS API protocol was recently extended with numeric `null`, >`, `>=`, `<` and `<=` match operators. These operators should be provided by SDK so users could use them in their access rules. Signed-off-by: Leonard Lyubich <[email protected]>
Handle recently added `MatchType` values by `Validator` to support integer comparisons and attribute absence. Non-decimal filter and/or header value used with numeric matcher is considered as mismatching rule. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
feature/eacl-numeric-ops
branch
from
ac151c2 to
a31bd91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.