fix/Child objects ACL #543
Conversation
carpawell
requested review from
roman-khimov,
cthulhu-rider and
smallhive
as code owners
object/object.go
Outdated
| } | ||
|
|
||
| // todo | ||
| func (o *Object) InitID() (v oid.ID, isSet bool) { |
There was a problem hiding this comment.
I suggest replacing isSet with error. Anyway, we return the second variable. The error is more informative and sometimes required to understand what it is
There was a problem hiding this comment.
agree it can be improved somehow but suggest doing it all together (these flags are common to the Object)
carpawell
force-pushed
the
fix/small-objects-acl
branch
2 times, most recently
from
db0231f to
df4081c
Compare
My IDE says they are vulnerable: - github.com/containerd/containerd v1.7.13 - github.com/opencontainers/runc v1.1.8 Signed-off-by: Pavel Karpy <[email protected]>
Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/small-objects-acl
branch
from
2f08bda to
c9eeaeb
Compare
object/splitinfo.go
Outdated
| @@ -39,7 +39,8 @@ func (s *SplitInfo) ToV2() *object.SplitInfo { | |||
| return (*object.SplitInfo)(s) | |||
| } | |||
|
|
|||
| // SplitID returns [SplitID] if it has been set. | |||
| // SplitID returns [SplitID] if it has been set.New objects may miss it, | |||
There was a problem hiding this comment.
| // SplitID returns [SplitID] if it has been set.New objects may miss it, | |
| // SplitID returns [SplitID] if it has been set. New objects may miss it, |
object/link.go
Outdated
| oid "github.com/nspcc-dev/neofs-sdk-go/object/id" | ||
| ) | ||
|
|
||
| // Link represents a helper object with information about |
There was a problem hiding this comment.
object/link.go
Outdated
| // [Object.WriteLink]/[Object.ReadLink]. | ||
| type Link v2object.Link | ||
|
|
||
| // WriteLink writes [Link] to the [Object], and sets its type to [TypeLink]. |
There was a problem hiding this comment.
[...] notations for prms are redundant: they all are links already (e.g. https://pkg.go.dev/github.com/nspcc-dev/[email protected]/object#Object.WriteLock)
There was a problem hiding this comment.
dropped but i cannot understand why it is a problem. i literally copied the Lock docs (like from the link), what should your link say to me?
There was a problem hiding this comment.
I'd rather have [Link], but if it's autodetected for these cases then it's not an error at least to not have brackets.
Includes the new LINK object (type and fixed payload) and the first object part instead of split ID. Signed-off-by: Pavel Karpy <[email protected]>
- Split ID is deprecated; - First object part is a replacement for Split ID: every part should have its ID, and also it has a root object header (without payload fields); - Link object now stores child objects as a payload and has its own object type. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/small-objects-acl
branch
from
c9eeaeb to
e1a82c5
Compare
Fixed but #554 (comment). That was the reason i missed it. |
No description provided.