Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: update upload-bin to create index files during block uploading #3735

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

AliceInHunterland
Copy link
Contributor

Close #3655
Close #3652

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 114 lines in your changes missing coverage. Please review.

Project coverage is 83.03%. Comparing base (5f92da2) to head (62615f8).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
cli/util/upload_bin.go 4.20% 114 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3735      +/-   ##
==========================================
+ Coverage   82.91%   83.03%   +0.12%     
==========================================
  Files         335      335              
  Lines       46847    46763      -84     
==========================================
- Hits        38841    38829      -12     
+ Misses       6411     6336      -75     
- Partials     1595     1598       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, I didn't find bugs in the proposed code. Let's fix minor issues and merge.

docs/neofs-blockstorage.md Outdated Show resolved Hide resolved
cli/util/upload_bin.go Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
docs/neofs-blockstorage.md Outdated Show resolved Hide resolved
docs/neofs-blockstorage.md Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested the updated version?

cli/util/upload_bin.go Outdated Show resolved Hide resolved
docs/neofs-blockstorage.md Outdated Show resolved Hide resolved
@AliceInHunterland
Copy link
Contributor Author

Yes, I have tested it on apollon net.

@AnnaShaleva
Copy link
Member

Something has happened with Tests / Lint: scripts / Lint (pull_request) job. I'm sure it was OK several PRs ago.

@AnnaShaleva
Copy link
Member

OK, it's due to #3746 and #3747.

@AnnaShaleva AnnaShaleva merged commit cb4b21f into master Dec 12, 2024
32 of 34 checks passed
@AnnaShaleva AnnaShaleva deleted the index-files-put branch December 12, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants