-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: update upload-bin
to create index files during block uploading
#3735
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3735 +/- ##
==========================================
+ Coverage 82.91% 83.03% +0.12%
==========================================
Files 335 335
Lines 46847 46763 -84
==========================================
- Hits 38841 38829 -12
+ Misses 6411 6336 -75
- Partials 1595 1598 +3 ☔ View full report in Codecov by Sentry. |
28a9f70
to
fb9dd64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM, I didn't find bugs in the proposed code. Let's fix minor issues and merge.
fb9dd64
to
448e59f
Compare
448e59f
to
cb86760
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested the updated version?
Close #3655 Close #3652 Signed-off-by: Ekaterina Pavlova <[email protected]>
cb86760
to
62615f8
Compare
Yes, I have tested it on apollon net. |
Something has happened with |
Close #3655
Close #3652