Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused casparcg useScheduling option #294

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix: remove unused casparcg useScheduling option #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/timeline-state-resolver-types/src/generated/casparCG.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ export interface CasparCGOptions {
* Interval (ms) for retrying to load media that previously failed. (-1 disables, 0 uses the default interval)
*/
retryInterval?: number
/**
* whether to use the CasparCG-SCHEDULE command to run future commands, or the internal (backwards-compatible) command queue
*/
useScheduling?: boolean
}

export interface MappingCasparCGLayer {
Expand Down
1 change: 0 additions & 1 deletion packages/timeline-state-resolver/examples/testChangeTimelineQuickly.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ const a = async function () {
await tsr.addDevice('casparcg0', {
type: DeviceType.CASPARCG,
options: {
// useScheduling: true,
host: '127.0.0.1',
// port: 5250
},
Expand Down
6 changes: 0 additions & 6 deletions packages/timeline-state-resolver/src/integrations/casparCG/$schemas/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,6 @@
"ui:title": "Media retry interval",
"ui:description": "Time between retries for media that could not be loaded on first try. Set to -1 to disable.",
"default": 0
},
"useScheduling": {
"type": "boolean",
"description": "whether to use the CasparCG-SCHEDULE command to run future commands, or the internal (backwards-compatible) command queue",
"ui:title": "Use CasparCG Timecode Scheduler",
"default": false
}
},
"required": ["host"],
Expand Down
20 changes: 0 additions & 20 deletions packages/timeline-state-resolver/src/integrations/casparCG/__tests__/casparcg.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: true,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -134,7 +133,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: true,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -202,7 +200,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: false,
fps: 50,
},
commandReceiver: commandReceiver0,
Expand Down Expand Up @@ -285,7 +282,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: false,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -359,7 +355,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: true,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -449,7 +444,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: true,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -529,7 +523,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: true,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -610,7 +603,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: true,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -727,7 +719,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: true,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -847,7 +838,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: true,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -986,7 +976,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: true,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -1092,7 +1081,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: true,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -1197,7 +1185,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: true,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -1298,7 +1285,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: true,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -1388,7 +1374,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: true,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -1473,7 +1458,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: false,
retryInterval: undefined, // disable retries explicitly, we will manually trigger them
},
commandReceiver: commandReceiver0,
Expand Down Expand Up @@ -1601,7 +1585,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: false,
retryInterval: undefined, // disable retries explicitly, we will manually trigger them
},
commandReceiver: commandReceiver0,
Expand Down Expand Up @@ -1731,7 +1714,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: false,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -1828,7 +1810,6 @@
type: DeviceType.CASPARCG,
options: {
host: '127.0.0.1',
useScheduling: false,
},
commandReceiver: commandReceiver0,
skipVirginCheck: true,
Expand Down Expand Up @@ -1915,12 +1896,12 @@
})
})

// describe('CasparCG - Custom transitions', () => {

Check warning on line 1899 in packages/timeline-state-resolver/src/integrations/casparCG/__tests__/casparcg.spec.ts

View workflow job for this annotation

GitHub Actions / Lint (timeline-state-resolver) 

Some tests seem to be commented

Check warning on line 1899 in packages/timeline-state-resolver/src/integrations/casparCG/__tests__/casparcg.spec.ts

View workflow job for this annotation

GitHub Actions / Lint (timeline-state-resolver) 

Some tests seem to be commented
// const mockTime = new MockTime()
// beforeEach(() => {
// mockTime.init()
// })
// test('FILL', async () => {

Check warning on line 1904 in packages/timeline-state-resolver/src/integrations/casparCG/__tests__/casparcg.spec.ts

View workflow job for this annotation

GitHub Actions / Lint (timeline-state-resolver) 

Some tests seem to be commented

Check warning on line 1904 in packages/timeline-state-resolver/src/integrations/casparCG/__tests__/casparcg.spec.ts

View workflow job for this annotation

GitHub Actions / Lint (timeline-state-resolver) 

Some tests seem to be commented
// const commandReceiver0: any = jest.fn(async () => {
// return Promise.resolve()
// })
Expand All @@ -1943,7 +1924,6 @@
// type: DeviceType.CASPARCG,
// options: {
// host: '127.0.0.1',
// useScheduling: false,
// retryInterval: undefined, // disable retries explicitly, we will manually trigger them
// },
// commandReceiver: commandReceiver0,
Expand Down