Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused casparcg useScheduling option #294

Merged

Conversation

Julusian
Copy link
Member

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix

  • What is the current behavior? (You can also link to an open issue here)

The option useScheduling for the casparcg device is not used in the code, as it appears to be no longer supported by casparcg-connection

  • What is the new behavior (if this is a feature change)?

Option is removed

  • Other information:

@Julusian Julusian requested a review from a team September 29, 2023 14:51
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e259f5c) 34.82% compared to head (91814b3) 34.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           release50     #294   +/-   ##
==========================================
  Coverage      34.82%   34.82%           
==========================================
  Files             99       99           
  Lines          10120    10120           
  Branches        2481     2481           
==========================================
  Hits            3524     3524           
  Misses          6009     6009           
  Partials         587      587           
Files Coverage Δ
...ine-state-resolver-types/src/generated/casparCG.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian merged commit 06d3c96 into release50 Oct 2, 2023
36 checks passed
@Julusian Julusian deleted the fix/remove-unused-casparcg-use-scheduling-option branch November 16, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants