Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onDidSave event handling #28

Closed
wants to merge 2 commits into from
Closed

Fix onDidSave event handling #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebcfe6a
Fix `onDidSave` event handling
mgoggin Dec 12, 2022
eedfa1e
Clean up event handlers on extension deactivation
mgoggin Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 36 additions & 14 deletions Scripts/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ const { isRailsInProject, showNotification } = require("./helpers")
const versionChecker = new VersionChecker()
versionChecker.check()

const eventHandlers = []

let langserver = null
let sidebar = null

Expand Down Expand Up @@ -35,21 +37,33 @@ exports.activate = function() {
}

if (SETTINGS.rubocop.autocorrectOnSave()) {
nova.workspace.activeTextEditor.onDidSave((editor) => {
const rubocop = new COMMANDS.Rubocop()

switch (SETTINGS.rubocop.autocorrectOnSave()) {
case "Layout (recommended)":
rubocop.autocorrectLayout(editor.document)
break
case "Safe Cops":
rubocop.autocorrect(editor.document)
break
case "Safe & Unsafe Cops":
rubocop.autocorrectAll(editor.document)
break
}
const didAddTextEditorHandler = nova.workspace.onDidAddTextEditor((editor) => {
const didSaveHandler = editor.onDidSave((editor) => {
const rubocop = new COMMANDS.Rubocop()

switch (SETTINGS.rubocop.autocorrectOnSave()) {
case "Layout (recommended)":
rubocop.autocorrectLayout(editor.document)
break
case "Safe Cops":
rubocop.autocorrect(editor.document)
break
case "Safe & Unsafe Cops":
rubocop.autocorrectAll(editor.document)
break
}
})

eventHandlers.push(didSaveHandler)

const didDestroyHandler = editor.onDidDestroy(() => {
didSaveHandler.dispose()
})

eventHandlers.push(didDestroyHandler)
})

eventHandlers.push(didAddTextEditorHandler)
}
}

Expand All @@ -65,6 +79,14 @@ exports.deactivate = function() {
sidebar = null
}

if (eventHandlers && eventHandlers.length > 0) {
console.log("Removing bound event handlers.")

while (handler = eventHandlers.pop()) {
handler.dispose()
}
}

console.log("Goodbye from Ruby on Rails 🚂")
}

Expand Down